Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change DELETE response status codes from 200 to 204 #25

Open
JoelSmith123 opened this issue Feb 4, 2019 · 2 comments
Open

Change DELETE response status codes from 200 to 204 #25

JoelSmith123 opened this issue Feb 4, 2019 · 2 comments

Comments

@JoelSmith123
Copy link
Owner

DELETE responses don't need a message, just the status codes, the messages can be deleted.

202 error code means the request has been accepted but not processed. It's not applicable for our DELETE methods.

204 error code means the requested item has been successfully deleted and is applicable for DELETE methods.
@mike-duke
Copy link
Contributor

mike-duke commented Feb 5, 2019 •
edited
Loading

i'm not sure how to add myself to this one, but i'll go ahead and take it if that's okay.

@mike-duke
Copy link
Contributor

Also, when i tried to push up to the repo, i got a "permission denied" error. i'm not sure if there is a setting to change it so that other contributors can post a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoelSmith123 @mike-duke