Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'last easter' gives NPE since 2021 #278

Open
d2a-raudenaerde opened this issue Jan 4, 2021 · 3 comments
Open

'last easter' gives NPE since 2021 #278

d2a-raudenaerde opened this issue Jan 4, 2021 · 3 comments

Comments

@d2a-raudenaerde
Copy link

d2a-raudenaerde commented Jan 4, 2021

    final List<DateGroup> groups = new Parser().parse("last easter", new Date(121, 1, 1));
java.lang.NullPointerException
	at java.base/java.util.Date.getMillisOf(Date.java:956)
	at java.base/java.util.Date.after(Date.java:929)
	at com.joestelmach.natty.WalkerState.seekToIcsEvent(WalkerState.java:571)
	at com.joestelmach.natty.WalkerState.seekToHoliday(WalkerState.java:393)
	at com.joestelmach.natty.generated.DateWalker.seek(DateWalker.java:1376)
	at com.joestelmach.natty.generated.DateWalker.relative_date(DateWalker.java:713)
	at com.joestelmach.natty.generated.DateWalker.date(DateWalker.java:659)
	at com.joestelmach.natty.generated.DateWalker.date_time(DateWalker.java:585)
	at com.joestelmach.natty.generated.DateWalker.date_time_alternative(DateWalker.java:532)
	at com.joestelmach.natty.generated.DateWalker.parse(DateWalker.java:418)
	at com.joestelmach.natty.Parser.singleParse(Parser.java:220)
	at com.joestelmach.natty.Parser.parse(Parser.java:100)

@d2a-raudenaerde
Copy link
Author

    final List<DateGroup> groups = new Parser().parse("last easter", new Date(121, 1, 1));

@d2a-raudenaerde d2a-raudenaerde changed the title 'last easter' returns null since 2021 'last easter' gives NPE since 2021 Jan 4, 2021
@mccartney
Copy link

It's because the hard-coded festival dates are up to ~2020:
https://github.com/joestelmach/natty/blob/master/src/main/resources/holidays.ics

@arobles-BB
Copy link

USA up to 2030

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants