Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect interpretation of maxValue / minValue when values are negatives #35

Closed
glebiller opened this issue Apr 18, 2013 · 1 comment
Closed

Comments

@glebiller
Copy link

It seems to have an issue when values are interpreted as Strings and values are negative. The comparison does not work the way it should, and the maxValue / minValue calculation is wrong.

To fix the issue, I have added a "parseFloat(value)" at first line of the method "TimeSeries.append".

I think it should be safer to include it in the code instead of making sure people are sending numeric values. When working with JSON this is not always true :)

@drewnoakes
Copy link
Collaborator

Issue #45 duplicated this issue, and provided a patch that has now been merged. I'll close this too. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants