Resize to side node #910
Resize to side node #910
Conversation
A new resize node that resizes an image to a desired target size on a given side while keeping aspect ratio
Added Size Preview to node.
Ran test with > npm run test-js -- -U and added the files.
Added a missing whitespace
|
Also this partially fulfils #798 |
Added a Resize Condition dropdown with options: Upscale And Downscale, Upscale Only, Downscale Only.
|
build checks fail after my recent "Resize Condition" push. It was fine before. Hmmm |
removed a few redundant cases
|
Holy shit that's a large type definition... Maybe we should start putting these in their own files? @RunDevelopment would need to take care of that though. Maybe we can worry about that when we refactor how node files work. Btw, there's a lot of repeated code in this. Consider extracting out the repeated stuff into their own methods. |
|
The type definition can probably be shortened a bit by using a single
You mean the python part? I can do that |
Method is now called from utils.py and differentiates between upscale and downscale so there should be no redundant lines
Added a new node that resizes an image while keeping aspect ratio. Resize targets are width, height, shorter side and longer side.
Previously this was only possible through the combination of 3 math nodes and a resize (factor) node