Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 #4

Merged
merged 6 commits into from
May 27, 2017
Merged

V2 #4

merged 6 commits into from
May 27, 2017

Conversation

deankarn
Copy link
Owner

@deankarn
Update ProxyFn signature
51aad6b 
ProxyFn now also accept the download aka download index or download chunk # and is no longer concatenated into the name by default;
this allows for the receiver to decided how to combine, if at all.

rename examples to _examples to avoid pulling in example dependencies with this library.
@deankarn
Deal with open files handles if error occurs.
d78f300 
closes #3
@deankarn
Concurrency cleanup.
1928366
@deankarn
Add RequestFn and ClientFn
d80769c 
- RequestFn allows access to the request for download to add http header, authentication etc...
- clientFn allows using a custom http.Client

closes #1, #2
@deankarn
HEAD request now uses custom http.Client
89186a7
@deankarn
Update version
b27d0e3
@deankarn deankarn self-assigned this May 27, 2017
@coveralls
Copy link

coveralls commented May 27, 2017 •
edited
Loading

Coverage Status

Coverage increased (+3.04%) to 91.318% when pulling b27d0e3 on v2 into c6c9e76 on master.

@deankarn deankarn merged commit 7a84e61 into master May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@deankarn deankarn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure file handles closed on error Allow custom http.Client ?
2 participants
@deankarn @coveralls