Fix divergence of real part of hankelH1 and hankelH2 at small |z| #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix divergence of real part of hankelH1 and hankelH2 at low |z|.
joeydumont
changed the title
|
This approach is doomed to fail without either a thorough mathematical analysis, or proper error checking. Should start again with the error handling code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11.
The real part of hankelH1 and hankelH2 overflows for small |z|, breaking the relationship
hankelH_\nu(z) = J_\nu(z) ± i Y_\nu(z). Trying to find the source of that overflow and fixing it.A workaround is to choose a given value of |z| < 1 for which we compute hankelH with the relationship above, but it should be possible to isolate the source of the overflow and fix it.