Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with update #16

Closed
Bustami opened this issue Dec 8, 2018 · 6 comments
Closed

Problems with update #16

Bustami opened this issue Dec 8, 2018 · 6 comments

Comments

@Bustami
Copy link

Bustami commented Dec 8, 2018

Hi there
I'm tryng to use the last updates but i got some errors:

Error in soccerShotmap(., theme = "grass", colGoal = "yellow", colMiss = "blue", :
unused arguments (colGoal = "yellow", colMiss = "blue", legend = T)

Error in soccerPassmap(., fill = "blue", minPass = 3, edge_max_width = 30, :
unused arguments (edge_max_width = 30, edge_col = "grey40", edge_alpha = 1)

I installed the 0.9.3 version. Is it the last version?

Thanks

@JoGall
Copy link
Owner

JoGall commented Dec 10, 2018

Whoops, didn't mean to push the tarball for 0.9.3! If you're after the latest version, just use devtools to install from source.

@JoGall JoGall closed this as completed Dec 10, 2018
@Bustami
Copy link
Author

Bustami commented Dec 10, 2018

Thanks!
The problem now is devtools function "install_github" has a bug, so i got:
devtools::install_github("jogall/soccermatics")

Error in read.dcf(path) :
Found continuation line starting ' 'soccerFlipDirec ...' at begin of record.

Could you update the .tar.gz file in order to donwload and install it locally?

@JoGall JoGall reopened this Dec 10, 2018
@JoGall
Copy link
Owner

JoGall commented Dec 10, 2018

Hmm it sounds like the documentation might have been malformed but I can't see what -- maybe some unexpected Git merging behaviour as I develop on both Linux and Windows.

Can you try using devtools one more time? I've updated the tarball (v0.9.3) but think the issue will affect that too if it persists..

@Bustami
Copy link
Author

Bustami commented Dec 10, 2018

Yep. I tried again and got a different error:

Error in parse(outFile) :
.../AppData/Local/Temp/Rtmpw9fJrK/devtools296865146a03/JoGall-soccermatics-7a3c9d2/R/soccerxGTimeline.R:126:1: inesperado '=='
125: }
126: ==
^

@JoGall
Copy link
Owner

JoGall commented Dec 11, 2018

Mais uma vez, por favor..

@Bustami
Copy link
Author

Bustami commented Dec 11, 2018

Another error:

Error in read.dcf(path) :
Found continuation line starting ' 'soccerFlipDirec ...' at begin of record

I also downloaded the 0.9.3 tar and successfully install it locally, but it doesn't have the arguments from update.

Anyway, i could do some viz without these arguments. Don't worry. Thanks mate!

@JoGall JoGall closed this as completed Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants