Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing timestamp that breaks chronological order #4

Closed
johanbaaij opened this issue Apr 9, 2020 · 1 comment · Fixed by #5
Closed

Passing timestamp that breaks chronological order #4

johanbaaij opened this issue Apr 9, 2020 · 1 comment · Fixed by #5
Assignees
@johanbaaij
Labels
released

Comments

@johanbaaij
Copy link
Owner

Describe the bug
When passing a timestamp that breaks chronological order the calculated BPM is incorrect.

To Reproduce

counter.taps
// -> [0, 500, 1000, 1500]

counter.bpm
// -> 120

counter.tap(250)
counter.bpm
// -> 960

Expected behavior
reset() should be called.
@johanbaaij johanbaaij self-assigned this Apr 9, 2020
@johanbaaij johanbaaij mentioned this issue Apr 9, 2020
Merged
@github-actions
Copy link

github-actions bot commented Apr 9, 2020

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johanbaaij johanbaaij

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 4 passing timestamp that breaks chronological order johanbaaij/bpm-counter
1 participant
@johanbaaij