-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong way to determine Bubble's firmware #36
Comments
bjornoleh
added a commit
to bjornoleh/xdripswift
that referenced
this issue
Feb 25, 2023
Copied from LoopKit/LoopWorkspace#36 Validate repository secrets (JohanDegraeve#36) * Validate repository secrets Adds support for validation of repository secrets. * Validate $FASTLANE_KEY as unencrypted PKCS#8 * Number workflows to guide sequential exection
bjornoleh
added a commit
to bjornoleh/xdripswift
that referenced
this issue
May 29, 2023
Copied from LoopKit/LoopWorkspace#36 Validate repository secrets (JohanDegraeve#36) * Validate repository secrets Adds support for validation of repository secrets. * Validate $FASTLANE_KEY as unencrypted PKCS#8 * Number workflows to guide sequential exection
bjornoleh
added a commit
to bjornoleh/xdripswift
that referenced
this issue
May 29, 2023
Copied from FreeAPS-X, not yet adapted to Xdrip4iOS. Originally based on FastLane and GitHub Actions from LoopKit/LoopWorkspace Adapt Fastfile and workflow file, rename workflow file to build_xdrip.yml Adapt instructions to Xdrip4iOS Fastfile: fix scheme (xdrip) xDrip.xcconfig: MAIN_APP_BUNDLE_IDENTIFIER = com.$(DEVELOPMENT_TEAM).xdripswift Add CURRENT_PROJECT_VERSION = $(CURRENT_PROJECT_VERSION) to xDrip and xdrip4iOS Widget targets testflight.md instructions: Add NFC Tag Reading to xdripswift App ID -and some adjustments to identifier names Validate repository secrets Copied from LoopKit/LoopWorkspace#36 Validate repository secrets (JohanDegraeve#36) * Validate repository secrets Adds support for validation of repository secrets. * Validate $FASTLANE_KEY as unencrypted PKCS#8 * Number workflows to guide sequential exection Add commented-out template for automated builds on push and on schedule (every two months) Users must uncomment (remove "#") from the start of the lines indicated in the workflow to enable automated builds. testflight.md: Add Validate Secrets instructions, and add numbered workflows. testflight.md: Add info about TestFlight on a child’s phone testflight.md: add info about steps to re-use for "Browser Builds" of other apps Add NFC tag reading capability to TestFlight app from Fastfile Remove step for manual setup of NFC tag reading capability from testflight.md Always upload artifacts build_xdrip.yml: remove "secrets" job No need to validate secrets for every build. This can be done by running Validate secrets manually. - remove "with: submodules: recursive" from Checkout action build_xdrip.yml: Add branch name to run-name testflight:md: update instructions Build on macos-13 and Xcode 14.3 macos-13 is still in beta as GitHub Actions runner, but works well. Available Xcode versions are listed here, Xcode 14.2 is currently the default: https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md#xcode Sync changes from upstream, and keep repository "alive" The keep alive action allow scheduled runs beyond the 60 day repo inactivity limit for scheduled GitHub Actions
bjornoleh
added a commit
to bjornoleh/xdripswift
that referenced
this issue
May 31, 2023
Copied from FreeAPS-X, not yet adapted to Xdrip4iOS. Originally based on FastLane and GitHub Actions from LoopKit/LoopWorkspace Adapt Fastfile and workflow file, rename workflow file to build_xdrip.yml Adapt instructions to Xdrip4iOS Fastfile: fix scheme (xdrip) xDrip.xcconfig: MAIN_APP_BUNDLE_IDENTIFIER = com.$(DEVELOPMENT_TEAM).xdripswift Add CURRENT_PROJECT_VERSION = $(CURRENT_PROJECT_VERSION) to xDrip and xdrip4iOS Widget targets testflight.md instructions: Add NFC Tag Reading to xdripswift App ID -and some adjustments to identifier names Validate repository secrets Copied from LoopKit/LoopWorkspace#36 Validate repository secrets (JohanDegraeve#36) * Validate repository secrets Adds support for validation of repository secrets. * Validate $FASTLANE_KEY as unencrypted PKCS#8 * Number workflows to guide sequential exection Add commented-out template for automated builds on push and on schedule (every two months) Users must uncomment (remove "#") from the start of the lines indicated in the workflow to enable automated builds. testflight.md: Add Validate Secrets instructions, and add numbered workflows. testflight.md: Add info about TestFlight on a child’s phone testflight.md: add info about steps to re-use for "Browser Builds" of other apps Add NFC tag reading capability to TestFlight app from Fastfile Remove step for manual setup of NFC tag reading capability from testflight.md Always upload artifacts build_xdrip.yml: remove "secrets" job No need to validate secrets for every build. This can be done by running Validate secrets manually. - remove "with: submodules: recursive" from Checkout action build_xdrip.yml: Add branch name to run-name testflight:md: update instructions Build on macos-13 and Xcode 14.3 macos-13 is still in beta as GitHub Actions runner, but works well. Available Xcode versions are listed here, Xcode 14.2 is currently the default: https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md#xcode Sync changes from upstream, and keep repository "alive" The keep alive action allow scheduled runs beyond the 60 day repo inactivity limit for scheduled GitHub Actions Remove $(SRCROOT)/ from INFOPLIST_FILE due to build error with Fastlane INFOPLIST_FILE = "$(SRCROOT)/xdrip/Supporting Files/Info.plist" Fastlane error: -Cannot set build number with plist path containing $(SRCROOT) -Please remove $(SRCROOT) in your Xcode target build settings More info: fastlane/fastlane#329 build_xdrip.yml: correct app name (xDrip4iOS) in workflow name Sync changes from upstream, and keep repository "alive" The keep alive action allow scheduled runs beyond the 60 day repo inactivity limit for scheduled GitHub Actions build_xdrip: SYNC_UPSTREAM: 'true' / 'false'
paulplant
pushed a commit
that referenced
this issue
Jun 2, 2023
…TestFlight distributions (#419) * Copy FastLane and GitHub Actions for Mac-free install Copied from FreeAPS-X, not yet adapted to Xdrip4iOS. Originally based on FastLane and GitHub Actions from LoopKit/LoopWorkspace * Adapt Fastfile and workflow file, rename workflow file to build_xdrip.yml * Adapt instructions to Xdrip4iOS * Fastfile: fix scheme (xdrip) * xDrip.xcconfig: MAIN_APP_BUNDLE_IDENTIFIER = com.$(DEVELOPMENT_TEAM).xdripswift * Add CURRENT_PROJECT_VERSION = $(CURRENT_PROJECT_VERSION) to xDrip and xdrip4iOS Widget targets * testflight.md instructions: Add NFC Tag Reading to xdripswift App ID -and some adjustments to identifier names * Validate repository secrets Copied from LoopKit/LoopWorkspace#36 Validate repository secrets (#36) * Validate repository secrets Adds support for validation of repository secrets. * Validate $FASTLANE_KEY as unencrypted PKCS#8 * Number workflows to guide sequential exection * Add commented-out template for automated builds on push and on schedule (every two months) Users must uncomment (remove "#") from the start of the lines indicated in the workflow to enable automated builds. * testflight.md: Add Validate Secrets instructions, and add numbered workflows. * testflight.md: Add info about TestFlight on a child’s phone * testflight.md: add info about steps to re-use for "Browser Builds" of other apps * Add NFC tag reading capability to TestFlight app from Fastfile Remove step for manual setup of NFC tag reading capability from testflight.md * Always upload artifacts * build_xdrip.yml: remove "secrets" job No need to validate secrets for every build. This can be done by running Validate secrets manually. - remove "with: submodules: recursive" from Checkout action * build_xdrip.yml: Add branch name to run-name * testflight:md: update instructions * Build on macos-13 and Xcode 14.3 macos-13 is still in beta as GitHub Actions runner, but works well. Available Xcode versions are listed here, Xcode 14.2 is currently the default: https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md#xcode * Remove $(SRCROOT)/ from INFOPLIST_FILE due to build error with Fastlane INFOPLIST_FILE = "$(SRCROOT)/xdrip/Supporting Files/Info.plist" Fastlane error: -Cannot set build number with plist path containing $(SRCROOT) -Please remove $(SRCROOT) in your Xcode target build settings More info: fastlane/fastlane#329 * build_xdrip.yml: correct app name (xDrip4iOS) in workflow name * Sync changes from upstream, and keep repository "alive" The keep alive action allow scheduled runs beyond the 60 day repo inactivity limit for scheduled GitHub Actions * build_xdrip: SYNC_UPSTREAM: 'true' / 'false'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As for the last commit of bubbledevteam to the master of xDrip (NightscoutFoundation/xDrip@672d073), the correct way to determine Bubble’s firmware is
let firmware = value[2].description + “.” + value[3].description
and not
let firmware = value[1].description + ".0"
(
xdripswift/xdrip/Transmitter/CGMBluetoothTransmitter/Libre/Bubble/CGMBubbleTransmitter.swift
Line 151 in f2d7bc5
The text was updated successfully, but these errors were encountered: