Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Annotations #7

Open
johandry opened this issue Mar 10, 2020 · 0 comments
Open

[Feature] Add Annotations #7

johandry opened this issue Mar 10, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@johandry
Copy link
Owner

Is your feature request related to a problem? Please describe.
This is a nice to have feature, it's not a problem yet

Describe the solution you'd like
All the objects modified by klient should have an specific annotation. Optionally, we can allow the developer to set it's own annotation.

Describe alternatives you've considered
As an alternative the annotation could be included in the content or file to apply.

Proposal
Before create or update the object call:

err := util.CreateOrUpdateAnnotation(annotation, info.Object, scheme.DefaultJSONEncoder())

to append this annotation to the object, this should be in the func called by r.Visit(info) such as create() and patch()

Additional context
It's in kubectl but it does append the annotation provided by the user

References
None

@johandry johandry self-assigned this Mar 10, 2020
@johandry johandry added the enhancement New feature or request label Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant