Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade bevy to 0.9 in demo #67

Merged
merged 12 commits into from Jan 12, 2023
Merged

upgrade bevy to 0.9 in demo #67

merged 12 commits into from Jan 12, 2023

Conversation

hfaulds
Copy link
Contributor

@hfaulds hfaulds commented Jan 4, 2023 •
edited

I know this is blocked on releases of ggrs and bevy_ggrs but I was curious what would be required to get this demo working using bevy 0.9 . Once I got it working I thought I might as well open a PR in case it's useful in the future.

XRef #55

@hfaulds hfaulds marked this pull request as draft January 4, 2023 11:22
hfaulds
hfaulds commented Jan 4, 2023
View reviewed changes
matchbox_demo/src/main.rs Outdated Show resolved Hide resolved
johanhelsing
johanhelsing reviewed Jan 10, 2023
View reviewed changes
Copy link
Owner

@johanhelsing johanhelsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, and sorry, I thought I already responded to this.

This is useful :) Do you want to finish it now that bevy_ggrs just released?

matchbox_demo/Cargo.toml Outdated Show resolved Hide resolved
matchbox_demo/src/box_game.rs Outdated Show resolved Hide resolved
matchbox_demo/src/box_game.rs Outdated Show resolved Hide resolved
matchbox_demo/src/main.rs Show resolved Hide resolved
matchbox_demo/src/main.rs Show resolved Hide resolved
matchbox_demo/src/main.rs Show resolved Hide resolved
matchbox_socket/Cargo.toml Outdated Show resolved Hide resolved
@hfaulds hfaulds marked this pull request as ready for review January 11, 2023 21:25
@hfaulds hfaulds changed the title WIP: get demo working using bevy 0.9 upgrade bevy to 0.9 in demo Jan 12, 2023
johanhelsing
johanhelsing requested changes Jan 12, 2023
View reviewed changes
matchbox_demo/src/main.rs Show resolved Hide resolved
matchbox_demo/src/main.rs Outdated Show resolved Hide resolved
matchbox_demo/Cargo.toml Outdated Show resolved Hide resolved
hfaulds
hfaulds commented Jan 12, 2023
View reviewed changes
matchbox_demo/Cargo.toml Outdated Show resolved Hide resolved
hfaulds
hfaulds commented Jan 12, 2023
View reviewed changes
matchbox_demo/Cargo.toml Outdated Show resolved Hide resolved
johanhelsing
johanhelsing requested changes Jan 12, 2023
View reviewed changes
Copy link
Owner

@johanhelsing johanhelsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go now :)

matchbox_demo/Cargo.toml Outdated Show resolved Hide resolved
matchbox_socket/Cargo.toml Outdated Show resolved Hide resolved
matchbox_demo/src/main.rs Outdated Show resolved Hide resolved
@hfaulds @johanhelsing
Apply suggestions from code review
f4274de 
Co-authored-by: Johan Klokkhammer Helsing <johanhelsing@gmail.com>
@johanhelsing johanhelsing self-requested a review January 12, 2023 15:28
johanhelsing
johanhelsing approved these changes Jan 12, 2023
View reviewed changes
Copy link
Owner

@johanhelsing johanhelsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in. Thanks a lot!

@johanhelsing johanhelsing merged commit f34b7af into johanhelsing:main Jan 12, 2023
@johanhelsing johanhelsing mentioned this pull request Jan 12, 2023
Closed
@hfaulds hfaulds deleted the hfaulds/demo-bevy-0.9 branch January 12, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanhelsing johanhelsing johanhelsing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hfaulds @johanhelsing