Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get actual breakpoints from defined BS4 css custom properties. #1

Closed
mattez opened this issue Dec 27, 2018 · 5 comments
Closed

Get actual breakpoints from defined BS4 css custom properties. #1

mattez opened this issue Dec 27, 2018 · 5 comments
Labels
enhancement New feature or request

Comments

@mattez
Copy link

mattez commented Dec 27, 2018

Is code getting actual breakpoints also from defined BS4 CSS custom properties? It seems they are only hardcoded inside script? Or I'm wrong?
Of course, values of breakpoints may vary from project to project. So the definition in the script would then have to be changed.
As you know, there are available CSS custom properties from which the current breakpoints values can be read:

:root {
...
    --breakpoint-xs: 0;
    --breakpoint-sm: 576px;
    --breakpoint-md: 768px;
    --breakpoint-lg: 992px;
    --breakpoint-xl: 1200px;
...
}

What do you think?

Discussion o about this twbs/bootstrap#25124 (comment)

@Johann-S
Copy link
Owner

You're right currently it's hardcoded, and that's an awesome idea, I'll add that 👍

@Johann-S Johann-S added the enhancement New feature or request label Dec 28, 2018
@Johann-S
Copy link
Owner

Done here: 69c4730 and 818394b

@Johann-S
Copy link
Owner

@mattez I'll make a release soon 😉

@mattez
Copy link
Author

mattez commented Dec 28, 2018

I recommend promoting this new feature somehow in the README. You will differ from your competitors :)

@Johann-S
Copy link
Owner

done 😉 thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants