Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M3 theme support #166

Open
json-derulo opened this issue Mar 28, 2024 · 2 comments
Open

M3 theme support #166

json-derulo opened this issue Mar 28, 2024 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@json-derulo
Copy link
Collaborator

json-derulo commented Mar 28, 2024

😦 Problem Statement

Angular Material v17.2 introduced experimental support for M3 theming. We can expect M3 support to be graduated to stable soon. Users of angular-material-css-vars should be able to use the new M3 theme, at the same time it should still be possible to use M2 if a project isn't ready to update just yet.

❔ Possible Solution

  1. angular-material-css-vars defaults to M3 with a possibility to opt-out and use M2
  2. angular-material-css-vars defaults to M2 with a M3 opt-in possibility (until M2 is officially deprecated)

Personally I would prefer to default to the same theme which Angular Material defaults to for new projects.

➕ Additional context

We are not planning to support M3 while it's experimental, as it is necessary to use the @angular/material-experimental package, which adds more complexity.

@json-derulo json-derulo added the enhancement New feature or request label Mar 28, 2024
@json-derulo json-derulo self-assigned this Mar 28, 2024
@json-derulo json-derulo pinned this issue Mar 28, 2024
@json-derulo
Copy link
Collaborator Author

The M3 theme has quite some differences with the M2 theme. There is no accent color anymore, and the warn color is now called error. Also there is a secondary color which will be chosen automatically, and a tertiary color. For more information, see the new theming guide.

It will not be trivial to add M3 support. For now, only M2 is supported. PRs to add M3 support are welcome.

@json-derulo json-derulo removed their assignment May 23, 2024
@json-derulo json-derulo added the help wanted Extra attention is needed label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants