-
Notifications
You must be signed in to change notification settings - Fork 32
ES6 promises not working #43
Comments
Yes definitely! Thanks for reporting and digging into this! Would you like to create a PR for this? |
PR created for you to review #44 Update: Noticed I hurt the code coverage. Not being as familiar with your tests, do you any free time to improve that for me? |
Thank you very much. I will do that! |
Awesome! I took some time to learn the tests before creating the PR, thought I almost had it, but hit a road block trying to create a native Definitely available to help if need be. |
I wonder how do you make es 6 promises work for you with angular1? I might have hit the same problem as you did. I added unit tests for them in these two commits: But I'm unable to get the unit tests to react to the promise being resolved no matter how many scope.$apply() I'm adding. |
|
I'm currently using ES6 with my Angular 1.5.X code. The promise button library is failing to resolve the promises because of this code block.
mVal.finally
is not a function with native ES6 promises. I noticed in your angular 2 version, you check for finally and then have a fallback.Is it possible to have this approach included into this repo as well.
The text was updated successfully, but these errors were encountered: