Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] New project clones last project #41

Closed
Morganamilo opened this issue Nov 30, 2017 · 3 comments
Closed

[Bug] New project clones last project #41

Morganamilo opened this issue Nov 30, 2017 · 3 comments
Labels

Comments

@Morganamilo
Copy link
Contributor

Your Environment

  • Version used: v1.6.7 e3928b4 deb
  • Operating System and version: Arch Linux 4.13.9-ck
  • Desktop Environment: i3

Expected Behavior

Create project should always make an empty project (i think, this could be intentional)

Current Behavior

Creating a project always clones the project that was made last

Steps to Reproduce (for bugs)

  1. Create project
  2. Add tasks
  3. Create new project
  4. Those tasks are copped into the new project

It always clones the project created last, so even if you switch projects it will still clone the last one. Not one you're currently using.

Also a side note, "Save current todo as project" with no project title brings up a toast notification "Project undefined successfully saved" but nothing actually happens. Wasn't sure if this deserved its own issue.

@johannesjo johannesjo added the bug label Nov 30, 2017
@johannesjo
Copy link
Owner

johannesjo commented Nov 30, 2017

No it's not in purpose (it is only, when you make a project from the stuff, you already started, while having none). Actually the whole data stuff could do with a huge refactor, but for that I would need more time than I currently have. But I definitely want to do it and maybe next year, I will have time for that.

@johannesjo
Copy link
Owner

johannesjo commented Nov 30, 2017

If you like to dive into the mess, these are the two files mainly responsible for handling project related stuff:

https://github.com/johannesjo/super-productivity/blob/develop/app-src/scripts/main/global-services/projects-s.js

https://github.com/johannesjo/super-productivity/blob/develop/app-src/scripts/main/global-services/app-storage-s.js

Otherwise the fix has to wait until after I'm back from vacation ;)

@Morganamilo
Copy link
Contributor Author

I'll have a look into it at some point maybe, I only really know vanilla JS though. electron and all that is a bit above me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants