Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

Different numbers in the "downloaded files" and "number of downloads" columns after downloading the blog due to the presence of duplicates in the blog #39

Closed
Taranchuk opened this issue Mar 9, 2017 · 6 comments

Comments

@Taranchuk
Copy link

If the blog contains a certain number of duplicates, which the program misses, then the "downloaded files" and "number of downloads" columns display different numbers after downloading. Say, the blog contains 1000 images, 50 of which are duplicates, then the program shows that 950 images have been downloaded and the "number of downloads" column displays a number of 1000 images. Because of this the progress bar becomes incomplete, does not reach a bit until the end, and therefore it seems that the blog has not downloaded completely. It would be convenient if you did so that the number of "number of downloads" would be less by the number of duplicates then it would be clear that the blog was downloaded completely

@Taranchuk
Copy link
Author

Taranchuk commented Mar 9, 2017

It turned out I at first did not understand the principle of the column "the number of downloads." It shows the total number of posts for all types: texts, images, video, audio and metadata. And I only download images and their metadata. So if the blog contains 1000 images, 100 videos and 1000 metadata images, then after downloading blog the "downloads" column will show the number 2000, and in the "number of downloads" column will show the number 2100, so even after reducing the number of downloads by the number of duplicates, the program will still be show different numbers between these columns. Is it possible to change this, let's say that the program took the number of downloads from the activated download modes, for example if the modes of downloading images and their metadata are selected, then the total number of downloads is taken only from them?

@johanneszab
Copy link
Owner

I think I've fixed it in the .27 release.

Thanks again for testing!

@Taranchuk
Copy link
Author

johanneszab, I downloaded the version 1.0.4.27 three day ago, the program still shows different numbers in the columns due to the presence of duplicates in the blogs.

@johanneszab
Copy link
Owner

Well, people will complain either way. If we subtract the the duplicates, people will come and complain that TumblThree downloads/detects less files than xxx downloader.

Honestly, I couldn't care less. For me it's mostly cosmetic. There are more important things to fix.

I've subtracted the duplicates now. I can guarantee you, someone will come and complain.

@Taranchuk
Copy link
Author

Thank you! Maybe it makes sense to written in a detail view of blogs that out of a total number of posts xxx duplicates were deducted? So that people would understand and they would not complain?

@CoWinkKeyDinkInc
Copy link

CoWinkKeyDinkInc commented Dec 15, 2018

This still seems like a problem in 1.0.8.68

When I remove and add the blog again, it gets a completely different number as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants