New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate functions for specific versions of Dynamic Time Warping #63
Conversation
…x-dtw-deprecation-issues
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
=========================================
Coverage ? 98.36%
=========================================
Files ? 91
Lines ? 4826
Branches ? 0
=========================================
Hits ? 4747
Misses ? 79
Partials ? 0
Continue to review full report at Codecov.
|
Deprecated functions: Updated function: New function: New pages in the documentation: |
@hichamjanati Feel free to add any comment regarding this PR (especially on the docstrings, if the descriptions are clear enough). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So all dtw_method
functions are deprecated but when a specific method arg is passed to dtw
the private funcs _dtw_method
are called ?
Is the plan is to remove those in the future as well and keep the minimal code:
-> compute region
-> compute accumulated cost
- eventually the
fast
andmulti-resolution
loops in private funcs ?
For the moment the private We also need a function for each method, just to have the corresponding docstring for the description of the options (although we could create a function with this docstring that would do nothing). |
of 'multiscale': the time series are downsampled so that the new time | ||
series are very small, the optimal path for these time series is computed | ||
and is projected at the scale that is two times larger. This process is | ||
repeated until the original scale of the time series is reached. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These descriptions are better than the ones provided in the individual docstrings. Maybe it's worth replacing them with these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's easier because we can talk about all the methods and how they relate to each other, while the individual docstrings need to be independent.
It's quite similar to scipy.optimize.minimize: the Notes
section is very detailed, while the docstring for each method (e.g. minimize(method='Nelder-Mead')) is very short and does not give much information.
Ah right, I forgot about the individual pages in the doc. Well the duplicated code is very small, I think it's not worth changing if we have to replace the func with empty ones. |
Good for me :) ! |
This PR deprecates the functions for specific versions of Dynamic Time Warping. Similarly to scipy.optimize.minimize, only the main function is in the public API, while all the functions for the specific methods are private.
Notable changes:
dtw_
functions are deprecated in 0.11 and will be removed in 0.12._dtw_*
, are kept and their docstrings are updated to describe only the method-specific parameters.show_options
has been added to show the options for each method.Some stuff in this PR is not related to this topic, just maintenance updates.