-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multiple & configureSecond #31
Conversation
β Deploy Preview for nuxt-gtag ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I will probably refactor the API a bit, but thanks for the effort nonetheless! |
@johannschopplich
|
Feel free to iterate once the next version is released and open a PR with simplifications and fixes. π |
@reslear I've released v1.2.0. Thanks for the hint on the init for multiple IDs. Would you mind doing a review on the latest code changes? Thanks in advance. π |
@johannschopplich Well I looked it up) looks good, but maybe I missed something? how implement analogue https://github.com/johannschopplich/nuxt-gtag/pull/31/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R253 ? case: |
@reslear Does the new module options beforehand meet your requirements? This is possible now and doesn't require a call like // `nuxt.config.ts`
export default defineNuxtConfig({
modules: ['nuxt-gtag'],
gtag: {
tags: [
{
id: 'GT-XXXXXXXXXX',
config: {
page_title: 'GA4'
}
},
{
id: 'DC-ZZZZZZZZZZ',
config: {
page_title: 'Floodlight'
}
}
]
}
}) |
@johannschopplich do you know what dynamic data is? I'm in advance, I don't know the gtag of my clients! |
Yep, I've built Nuxt API Party based on it. Your function If you think there's something missing, please open an issue and gladly open a new PR with your ideas. Thanks! |
yeah, no problem, I was just suggesting using Sugar's syntax. Thanks! |
@johannschopplich you need to do a review and apply eslint formatting since github.dev doesn't support it :)
π Linked issue
closes #30
β Type of change
π Description
π Checklist
sources: