Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support flake8:local-plugins #17

Open
adzenith opened this issue Feb 17, 2023 · 6 comments
Open

Support flake8:local-plugins #17

adzenith opened this issue Feb 17, 2023 · 6 comments

Comments

@adzenith
Copy link

Flake8 supports a second section in the setup.cfg that specifies local plugins. I'm not able to get that to work with this tool, and I took a look at the source and it looks like it only checks the normal flake8 section. Any chance support for this other section could be added?
Also just wanted to say thanks and that this project is amazing. 👍

@john-hen
Copy link
Owner

john-hen commented Feb 17, 2023

Thanks for pointing this out. Yeah, absolutely, that can be added. Do you want to do it?

I guess it's pretty straightforward to implement. Adding a meaningful test will be more difficult. But maybe we can do without a test in this case? I'm open to that if it complicates things too much. (Maybe because I won't be using that feature.)

@christianparpart

This comment was marked as off-topic.

@john-hen

This comment was marked as off-topic.

@christianparpart

This comment was marked as off-topic.

@tmarenko
Copy link

Seems it'd be quite hard. I took a look how flake8 loads plugins and how this project works.
You'd need to pass options for your local plugin right before plugin loading but this project, flake8-pyproject, itself is considered a flake8 plugin. Basically you can't hook anything before this line (before all plugins are registered) so seems it'd be quite difficult to load another plugin additionally after that.

@tmarenko
Copy link

tmarenko commented Dec 18, 2023

For anyone interested, I've made tests for local-plugins section: bed3c41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants