Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Damage in presentation #39

Closed
i509VCB opened this issue Dec 21, 2022 · 3 comments
Closed

Damage in presentation #39

i509VCB opened this issue Dec 21, 2022 · 3 comments
Labels
enhancement New feature or request Needs Design Work
Milestone

Comments

@i509VCB
Copy link
Contributor

i509VCB commented Dec 21, 2022

In order to efficiently draw on the CPU, it may be desireable to reduce how many pixels are actually drawn.

Often this involves telling the display server what pixels were changed so that the display server can reuse it's existing framebuffer or perform a partial upload of the texture data to the gpu to save pci bandwidth.

@notgull
Copy link
Member

notgull commented Dec 21, 2022

Maybe this could be another function, set_pixels_with_damage, where the user also passes in a "damage" value?

@i509VCB
Copy link
Contributor Author

i509VCB commented Dec 21, 2022

Also remembered that we would probably need to tell the user the age of the buffer.

@john01dav john01dav transferred this issue from rust-windowing/swbuf Dec 22, 2022
@john01dav john01dav added enhancement New feature or request Needs Design Work labels Dec 23, 2022
@jackpot51 jackpot51 added this to the 0.3 milestone Jan 6, 2023
@ids1024
Copy link
Member

ids1024 commented Apr 6, 2023

Now that #65 is merged, we could have a present_with_damage() method.

This is natural enough on Wayland. Do other backends have a way to support this?

ids1024 added a commit that referenced this issue Apr 26, 2023
Supported on Wayland, X11, and Win32.

Fixes #39.
@ids1024 ids1024 closed this as completed in c1d6716 Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Needs Design Work
Development

No branches or pull requests

5 participants