Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul acl resource is not defaulting to configured consul url and port #338

Closed
claudio-viola opened this issue Jul 20, 2016 · 2 comments
Closed

Comments

@claudio-viola
Copy link

https://github.com/johnbellone/consul-cookbook/blob/master/libraries/consul_acl.rb#L20
it should be
'http://#{node['consul']['config']['client_addr']:#{node['consul']['config']['ports']['http']}'

@claudio-viola claudio-viola changed the title consul acl is not defaulting to configured consul url and port consul acl resource is not defaulting to configured consul url and port Jul 24, 2016
@legal90
Copy link
Contributor

legal90 commented Dec 16, 2016

Hi @claudio-viola
Sorry, but it should not be so. url attribute of consul_asc resource defines the URL which will be used for sending the request. It accepts any TCP socket listened by a consul agent (it's not required to be local).

However, both of node['consul']['config']['client_addr'] and node['consul']['config']['ports']['http'] define how the local consul agent should be configured in case we want to set it up.
Those are a local address and port which the consul agent will use for listening.

Overall, node['consul']['config']['client_addr'] defaults to "0.0.0.0" which is OK for listening, but couldn't be used as a destination address for sending reqests (as consul_asc needs).

@legal90 legal90 closed this as completed Dec 16, 2016
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants