Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code #397

Merged
merged 2 commits into from Jan 17, 2017
Merged

Remove dead code #397

merged 2 commits into from Jan 17, 2017

Conversation

legal90
Copy link
Contributor

@legal90 legal90 commented Jan 12, 2017

  • "chef-sugar" - this dependency was removed in Remove redundant cookbook dependencies #387, but include_recipe worked fine only because it is included by "firewall::default". We still don't need it, so it could be removed.
  • "version" attribute is not defined in "consul_service" resource, it is not used and should not be passed there. Without chef-sugar it bombs this way:
       NoMethodError
       -------------
       undefined method `version' for ConsulCookbook::Resource::ConsulService

@codecov-io
Copy link

codecov-io commented Jan 12, 2017

Current coverage is 63.83% (diff: 100%)

No coverage report found for master at c639a3e.

Powered by Codecov. Last update c639a3e...a640bad

@legal90 legal90 merged commit b2fbd5f into sous-chefs:master Jan 17, 2017
@legal90 legal90 deleted the remove-sugar branch January 17, 2017 09:54
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants