fix(unplugin-vue-router)!: skip top-level route layout for index route children #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markthree
changed the title
markthree
changed the title
|
@markthree how does this interact with #136 ? |
These are two separate pr's, to make it easier to merge without conflicts I will update this code |
JohnCampionJr
approved these changes
Dec 27, 2023
|
@markthree thanks for this; all looks good to me. I just tried all of the examples and all behaved :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unplugin-vue-router adds a top-level route to the routing group, which we should skip, close #134
Although I've tested enough scenarios, feel free to let me know if you find any issues, plus this is a breaking change! 🤣