Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taking surrounding div out of normal css flow. #24

Closed
wants to merge 1 commit into from

Conversation

JustusW
Copy link

@JustusW JustusW commented May 31, 2020

Fixes #8

@johndatserakis
Copy link
Owner

Hey there @JustusW - thank you for the pr - yea #8 has come up in the past as an issue for some, although it's been tough to pin down the issue totally.

In reviewing your pr, I get this weird layering issue that isn't in the current release. We you seeing this in your development env? Also the sizing is no longer correct width wise as can been seen in the .gif.

Maybe one thing we can do is just simply add a class that users can attach to if they'd like to implement your solution.

It does seem like this issue is limited to unique-ish situations, like modals and other layered elements. So maybe this can be added as needed, and we'll have it mentioned in the docs on how to target the class to address the issue.

vue-simple-context-menu

What do you think?

@JustusW
Copy link
Author

JustusW commented Jun 8, 2020

I've since moved on to vuetify fap btn menues so I can't actually comment anymore :(
I've just made the pull request to offer a solution. Feel free to close/adapt/whatever.

@johndatserakis
Copy link
Owner

I see - ok that's no problem. I'll close this for now and we'll revisit it if someone can replicate the issue. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menus showing up off screen
2 participants