Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freezes on invalid name #6

Closed
eruizc-dev opened this issue Nov 21, 2020 · 1 comment
Closed

Freezes on invalid name #6

eruizc-dev opened this issue Nov 21, 2020 · 1 comment

Comments

@eruizc-dev
Copy link

Issue

Attempt to create a new package with an invalid name (not from params) causes the program to freeze.

Repro steps

  1. Call create-react-hook with no params
  2. When asked for package name include caps on it, for example myPackageName
  3. Program would freeze

Expected

Program should not freeze and print some sort of message

Workaround

The program is freezing on an error because package names should not include caps. Include the name as a param create-react-hook myPackageName and you will see the actual error:

Error: invalid package name "myPackageName"...

Additional notes

As I previously said, adding an invalid name from params prints the error. I expect them to behave similarly.

@eruizc-dev
Copy link
Author

eruizc-dev commented Nov 21, 2020

Howdy, I have no idea how it happened but I opened this issue in the wrong repo!

Here is the correct one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant