Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some icons are missing using Roundcube 1.0.1 with contextmenu 2.0 #37

Closed
lucaferrario opened this issue Jun 12, 2014 · 5 comments
Closed

Comments

@lucaferrario
Copy link

Hi!
I've installed the 2.0 version of the plugin on Roundcube 1.0.1.
It works, but some of the icons are missing, as you can see from the screenshot. Tested on latest Firefox and latest Chrome.

Many thanks and congratulations for this great plugin!!!

missing_icons

@johndoh
Copy link
Owner

johndoh commented Jun 14, 2014

The screenshot you gave is correct. There are no icons missing. Version 2 of this plugin is very different from version 1 where there were lots of icons. I thought icons on the sub menu headings was wrong because they dont actually do anything, just open the sub menu. I have not removed the icons themselves just the CSS that displays them so they could be added back quite easily. Icons on the sub menus come directly from the core, they are not controlled by this plugin.

@alecpl
Copy link
Contributor

alecpl commented Aug 7, 2014

Roundcube core uses icon in cases like e.g. Copy to/Move to. So, contextmenu could use them too.

@johndoh
Copy link
Owner

johndoh commented Aug 7, 2014

Do you have an example of where those icons are missing? They show up fine for me.

Icons that exist in the core (for example in the mark menu or the more actions menu) are used in contextmenu.

@alecpl
Copy link
Contributor

alecpl commented Aug 7, 2014

Hmm... Now I see them too. Anyway, would be nice to have also icons for actions that do not have icons in core (the core actions, not from plugins), i.e. Reply All, Forward, Mark, More, all actions in folder menu.

@johndoh
Copy link
Owner

johndoh commented Aug 7, 2014

I have the icons that I used in contextmenu v1 but I think some of them could use some work. I am not a graphic designer so this is a slow process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants