Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submenus with no icons should align text to right #44

Closed
alecpl opened this issue Aug 7, 2014 · 1 comment
Closed

Submenus with no icons should align text to right #44

alecpl opened this issue Aug 7, 2014 · 1 comment

Comments

@alecpl
Copy link
Contributor

alecpl commented Aug 7, 2014

Some submenus do not contain icons, e.g. Reply all, Forward, Export. They look strange with this left padding, it should be removed. I.e. do not use .iconized class if original element does not use it.

@johndoh
Copy link
Owner

johndoh commented Aug 7, 2014

I disagree. Having some menus indented and others not is inconsisten and, I think, looks messy. I did look at other context menus when I was implementing it, both in the browser and in desktop programs and they all maintain the indent. I think this is "normal".

@johndoh johndoh closed this as completed Aug 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants