Vimeo API Cleanup and Fix #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 21, 2014 05:56
This cleans up and fix missing Vimeo API methods. setVolume, setMuted and stopVideo should now work.
This cleans up and fix Vimeo API methods for setVolume and setMuted. setVolume on Vimeo is not accepting values from 0-100, but 0-1. mute() and unMute() is also not supported by Vimeo, so setMuted should be more convenient. Thanks!
ale-grosselle
pushed a commit
to ale-grosselle/mediaelement
that referenced
this pull request
Nov 25, 2016
Vimeo API Cleanup and Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the Vimeo API code and add the necessary missing API methods.