Fix #1499 Play button and loading animation not aligned. #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove code that tries to dynamically modify the CSS height of mejs-overlay-play and mejs-overlay-button. According to the comment, that code is intended for "special case for big play button so it doesn't go over the controls area". However, the code fails to achieve that: even with that code removed, the initial vertical position of the play button remains unchanged. Plus, it fixes the bug mentioned above.
johndyer
added a commit
that referenced
this pull request
Jul 31, 2015
Fix #1499 Play button and loading animation not aligned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove code that tries to dynamically modify the CSS height of mejs-overlay-play and mejs-overlay-button.
According to the comment, that code is intended for "special case for big play button so it doesn't go over the controls area". However, the code fails to achieve that: even with that code removed, the initial vertical position of the play button remains unchanged. Plus, it fixes the bug mentioned above.