Bugfix: Time float overflow #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this would be better if it were dynamic in some way. I'm guessing that most videos are under 1 hour, so we'd be leaving a lot of space for those. If we added a class to the main container for videos over one hour and then allowed that override the styles, it'd work for everyone. |
|
Sounds good, I'll give that a go. |
phuongdh
pushed a commit
to avalonmediasystem/mediaelement
that referenced
this pull request
Oct 18, 2013
Well done, sir!
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
Well done, sir!
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
Well done, sir!
marmite22
pushed a commit
to elucidat/mediaelement
that referenced
this pull request
Dec 16, 2016
Well done, sir!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the video being played is over an hour long, the timefloat text overflows. The pull request fixes this issue by widening the float to support the overflow.