Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible performance regression #12

Closed
omarkilani opened this issue Mar 24, 2011 · 3 comments
Closed

Possible performance regression #12

omarkilani opened this issue Mar 24, 2011 · 3 comments
Assignees

Comments

@omarkilani
Copy link

Hi John,

Not really a big deal and I'm not sure if this is related to the recent JKSerializer class, but I'm finding that encodes are 10-20% slower than my last test (with commit 524b9d7).

Do you see a similar drop?

Regards,
Omar

@johnezang
Copy link
Owner

No, I did not see any performance regressions. I typically do my testing on the x86_64 architecture using gcc-4.2 -DNS_BLOCK_ASSERTIONS -O2.

What architecture did you see the performance drop on? Did you use -DNS_BLOCK_ASSERTIONS? What optimization level?

@omarkilani
Copy link
Author

Hey John,

I forgot to define -DNS_BLOCK_ASSERTIONS while testing. :)

Sorry for the false alarm. Please close with an "Idiocy" label. :)

Keep up the awesome work on all your *Kits (I'd love to see TransactionKit resurrected one day. :)

Regards,
Omar

@johnezang
Copy link
Owner

Well I'm glad to hear that it wasn't an actual problem, as I really hoped to keep the JKSerializer object paradigm as it makes some things easier that I'm experimenting with. In particular, having an autoreleased object wrapper makes it easier to track resources and ensure they are released "no matter what"... like say if you added the ability for the user to "format" unhandled classes (i.e., NSDate), and the users code wasn't terribly careful and threw exceptions and what not. :)

As for TransactionKit... yea, that's a much, much more "interesting" project, but interesting and "lots of people use and like" aren't the same thing, or even remotely correlated. :)

@ghost ghost assigned johnezang May 21, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants