_JKDictionaryHashTableEntryForKey crashes for NULL capacity

[jkustan]

I have had great success using JSONKit -- however today I was getting a crash in _JKDictionaryHashTableEntryForKey. As I dug in, it seems that dictionary->capacity was NULL, and the code was dying here:

NSUInteger keyHash = CFHash(aKey), keyEntry = (keyHash % dictionary->capacity), idx = 0UL;

I added a NULL check immediately above:

if(!dictionary->capacity) { return(NULL); }

and now things seem to be going through.

Jack

[omarkilani]

I think this issue is a duplicate of #31 and was fixed in 18a0a3a.

Are you using the latest git version?

[jkustan]

I was using a 1.3 download, just moved up to 1.4, and manually added that
patch. Do you have a recommendation on using the latest vs. using the 1.4
download?

Thanks for putting this together!

Jack

On Wed, Jul 13, 2011 at 2:12 AM, omarkilani <
reply@reply.github.com>wrote:

I think this issue is a duplicate of #31 and was fixed in 18a0a3a.

Are you using the latest git version?

Reply to this email directly or view it on GitHub:
#38 (comment)

[johnezang]

As noted by @omarkilani, this is a known bug.

My personal recommendation is to use the latest from master (at least as of this date, which would be c2146ff).

I should probably create a stable branch as well that has all the patches since the last release.. hmmm.