Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set global header flag for all media types #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elkq
Copy link

@elkq elkq commented Oct 30, 2013

When the output format requires global headers,
CODEC_FLAG_GLOBAL_HEADER should be set for all codec media types.

This appears to be a very old bug, inherited from the 2009 version of output_example.c

This fix uses the same approach currently in new_output_stream()
in both avconv_opt.c and ffmpeg_opt.c (just search for CODEC_FLAG_GLOBAL_HEADER)

It is also present in a slightly different form in add_audio_stream() of libavformat/output-example.c
see: libav change 073189917e4dfa0640e8180110b07e130471f37f
Make output-example.c handle AAC audio.
Patch by Martin Storsjö martin martin st
Originally committed as revision 21367 to svn://svn.ffmpeg.org/ffmpeg/trunk

This change may fix the residual issues from "Leading silence (gaps) in audio segments",
but that needs to be confirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant