New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuilding and Fixing Snap Builds #1017
Comments
Thanks. But do you have a fix for the failing build? If you make a PR I'd be happy to merge and release it. |
That will be the best bet i believe, i will present you a PR soon... |
Thanks. So now I realize it's actually not possible to fix the current stable release (v2.6.4) because Snaps can only built from the default branch, which I've recently changed from |
I am seeing that, but there is one more solution for the snap one, we can simply repackage the foliate deb into snap and distribute, i will keep that in an alternate solution too.. |
@johnfactotum happy to say its at least building successfully, fixing the problem with gjs, i will update the pull request yaml in few days |
@johnfactotum can you give me some insight on this error, and any remedy will be help-full, the snap is build but wont run giving these error --> (gjs:10579): Gjs-ERROR **: 08:55:42.613: JS ERROR: Error: Requiring GjsPrivate, version none: Typelib file for namespace 'GjsPrivate' (any version) not found Trace/breakpoint trap (core dumped) |
No idea. The error comes not from the app but from GJS's internals. So probably GJS itself is not configured correctly or is missing some dependencies. |
Ok, i will try stuffing more gjs related dependencies and if still i dont get any results i will open this at snapcraft forum as the foliate snap is using gjs from snap gnome-platform sdk. |
@johnfactotum This is completed, i have successfully build the new yaml for foliate snap, please review accordingly, i have tested it works fine and also works fine with text to speech, i am willing and open to maintain the snap package for this project |
Now it says "Built, failed to release". |
Fixed It |
Thanks! It works now. Any chance that you could also make it build for other architectures? |
@johnfactotum What architectures do foliate support ?? |
Foliate itself is not architecture dependent. And GJS/GTK supports all the architectures supported by Snap, I think. Initially, the Snap worked for all the architectures, but IIRC, after fixing #324, it started to only build for amd64 and armhf. So the rest have been stuck at v2.1.1. |
I will try for arm atleast, and will also see others, i think it will be possible for all architectures now since we are using latest core 22... |
@johnfactotum i currently removed the arch part to let it try to build for all and it builds for three archs- arm64&hf and amd64 while fail for two others, i will limit the builds to these three archs in future, while ignoring the other two, currently implement this temporary solution. |
@johnfactotum Fixed, building for multiple archs |
@johnfactotum Is this complete ?? Should I close this, the snaps issue with not building is fixed plus i upgraded the snap to latest core22 so in future it will be easy to maintain a snap, and some other fixes with gjs were also fixed, i think this issue is complete, the recent issue regarding crash isnt snap specific as several non-snap users experience it |
Hey there @johnfactotum i wish to maintain and upkeep the foliate snap, so i request you to transfer the ownership of snap to me, i have filed request on the transfer please transfer it to me.
The text was updated successfully, but these errors were encountered: