-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow font size adjustment when using publisher fonts #34
Comments
Hmm, I think you've raised a very good point. I think I would rather like to keep the option labeled as "use publisher font" (there's no real semantic difference here; "use pub. font" == "don't force", and "force" == "don't use pub. font"), or "use publisher font if available", for clarity. I think the behavior should be:
The thing I'm unsure about is whether or not to unset |
on what? I hope headers and so on can still use different font-size, line-size and so on than the one the user sets. Especially if the epub author specifies something like I think font-size, colors and so on always should be allied only to the body. Also it would be interesting to see what calibre and so on do to apply the styles. I believe it works well in most of the cases. |
By "forced" I mean the current behavior when 'use publisher font' is disabled, to wit, size/ Also by "set font-family on everything" in Mode 2, I don't actually mean everything. I mean |
Fix commited in 462b788. |
Allowing to use the the publisher fonts works fine since #15, but that also causes the font size to be whatever the publisher chose.
My suggestion would be something like this:
Rename the option to "force custom font" or something along those lines.
body
(or maybehtml
?), but without!important
, so the book may override it while still being able to provide a font and size for books that don't specify them.The text was updated successfully, but these errors were encountered: