Change where defs live for MQ scripts #38
Conversation
Adding library path to the MQ install will give definitions, then the definitiosn live with the code
There was a problem hiding this comment.
An important thing to note, is that if your workspace root is set as your lua folder, you don't need to add the lua folder as a library path, so I think this should be mentioned and the path to the lua folder should be an optional step, should you chose to set it up that way (at least explain why you need it)
i want to get @johnfking 's opinion as well
| ], | ||
| } | ||
| ``` | ||
|
|
||
| Adding the absolute path to the macroquest binary lua folder will give type definitions for lua files shipped with Macroquest. |
There was a problem hiding this comment.
i'm worred that the word binary here can be misconstrued. This just needs to be the path to the lua folder, and its only necessary if you are developing from outside of lua folder tree.
I'd separate this out to be more clearly labeled an optional step, and why you'd need it.
| @@ -15,10 +15,14 @@ The extension can also be installed directly from within VSCode. Search Extensi | |||
| "Lua.runtime.version": "LuaJIT", | |||
| "Lua.workspace.library": [ | |||
| "./relative/path/to/mq-definitions", | |||
| "absolute/path/to/macroquest/lua", | |||
There was a problem hiding this comment.
I know this is a placeholder, but this placeholder isn't an absolute path either. absolute starts with a drive letter.
Adding library path to the MQ install will give definitions, then the definitiosn live with the code