Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DeCLUTR requirements? #253

Closed
piegu opened this issue Mar 17, 2022 · 5 comments
Closed

Update DeCLUTR requirements? #253

piegu opened this issue Mar 17, 2022 · 5 comments

Comments

@piegu
Copy link

piegu commented Mar 17, 2022

Hi,

Actual DeCLUTR needs Pytorch 1.6 because of the allennlp version used.
The actual version of Pytorch is 1.11 (March 2022).

Any plans to update DeCLUTR requirements?

Thanks.

@piegu piegu changed the title Update DeCLUTR? Update DeCLUTR requirements? Mar 17, 2022
@JohnGiorgi
Copy link
Owner

Hi,

Is this necessary? The setup.py pins allennlp to >=1.1.0, <1.2.0 which itself depends on torch, so installing DeCLUTR (via pip install git+https://github.com/JohnGiorgi/DeCLUTR.git) should give you the correct version of torch.

I just confirmed by running pip install git+https://github.com/JohnGiorgi/DeCLUTR.git in one of our example notebooks and that is indeed the case. See the truncated output below:

Collecting git+https://github.com/JohnGiorgi/DeCLUTR.git
  Cloning https://github.com/JohnGiorgi/DeCLUTR.git to /tmp/pip-req-build-19yvqrqh
  Running command git clone -q https://github.com/JohnGiorgi/DeCLUTR.git /tmp/pip-req-build-19yvqrqh
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
    Preparing wheel metadata ... done
Collecting allennlp<1.2.0,>=1.1.0
  Downloading allennlp-1.1.0-py3-none-any.whl (485 kB)
     |████████████████████████████████| 485 kB 4.3 MB/s 
Collecting torch<1.7.0,>=1.6.0
  Downloading torch-1.6.0-cp37-cp37m-manylinux1_x86_64.whl (748.8 MB)
     |████████████████████████████████| 748.8 MB 19 kB/s 

Are you having issues installing?

@piegu
Copy link
Author

piegu commented Mar 17, 2022

Hi @JohnGiorgi,

Thanks for your response (and for DeCLUTR!).
My problem is that I am doing a university research project that needs training DeCLUTR on a specific dataset.

Our great chance is that the university has a DGX A100 de NVIDIA (lucky we are) but... it appears that DGX A100 does not accept Pytorch 1.6

Then, with the current requirements, script and notebook training.ipynb, I can not train DeCLUTR.

Do you know how I could train it on DGX A100?

Thanks.

@JohnGiorgi
Copy link
Owner

Can you try updating torch to the version you need after installing DeCLUTR?

@piegu
Copy link
Author

piegu commented Mar 21, 2022

Hi @JohnGiorgi.

I did solve my problem thanks to a colleague:

  1. He installed the Pytorch release 20.07 with Pytorch 1.6 (release that fits with DGX A100 de NVIDIA).
  2. Then, he tried to install the DeCLUTR pip, but he had a problem, when installing a pytorch-metric-learning dependency, which the DeCLUTR repository requires, it kept trying to install the torch 1.10 cpu version of the pip library. This is not ideal, because the pytorch installation that comes in the container image is already optimized and built specifically to work with the versions of the CUDA drivers installed. He did not want to install another version of pytorch. So, he downloaded locally the "pytorch-metric-learning" and "allennlp" libraries repository and removed the pytorch dependency from within their setup.py. So forcing pip to install all the necessary dependencies except the torch that is already installed by the container image.

And it worked!

@JohnGiorgi
Copy link
Owner

Great! Glad you solved this. Not sure why installing pytorch-metric-learning installs the CPU version of pytorch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants