Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset? #1

Closed
timshim opened this issue Apr 10, 2014 · 6 comments
Closed

Reset? #1

timshim opened this issue Apr 10, 2014 · 6 comments

Comments

@timshim
Copy link

timshim commented Apr 10, 2014

Hi John, very nice work with the circle counter. I'm trying to implement it in an app now. I haven't been able to figure out how to do a 'reset'.

Also, another minor issue I noticed is that the animation isn't as smooth on longer timeframes. It looks great for ~10 secs.

Tim

@johngraham262
Copy link
Owner

Thanks! There's actually no specific reset yet. I'll check the outstanding PR and get back to you. Looks like someone has already added reset and an improved FPS.

@johngraham262
Copy link
Owner

Just updated the repo with an improved FPS and new reset method. Here's an update to the podspec.

Hope this helps!

@johngraham262
Copy link
Owner

(btw, I'm not sure why the README tests icon show builds as failing. If you click on it, the tests are passing and the icon shows success)

@timshim
Copy link
Author

timshim commented Apr 11, 2014

Man that's awesome! It works!

Two bugs I noticed in testing it again.

  1. It seems like the circlecounter isn't counting down correctly. I have a numerical timer attached and it doesn't sync up. It isn't as obvious on shorter timeframes.
  2. It also seems like the circlecounter pauses when the app goes into background.

@johngraham262 johngraham262 reopened this Apr 11, 2014
@johngraham262
Copy link
Owner

Hey, great feedback again.

Regarding (1.), check out this pull request: #3

(2.) This PR uses an NSTimer now; it provides the effect that the timer is still running in the background. If you do want to pause the timer before entering the background, you'll have to do that manually.

@johngraham262
Copy link
Owner

Merged and good to go, and it will be available via cocoapods when this is merged too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants