Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal does not cull occluded block faces #32

Closed
ChloeDawn opened this issue May 31, 2019 · 2 comments
Closed

Portal does not cull occluded block faces #32

ChloeDawn opened this issue May 31, 2019 · 2 comments
Labels
compatibility Third-party mod compatibility issues

Comments

@ChloeDawn
Copy link

ChloeDawn commented May 31, 2019

Better Portals version: 0.1.3
Better Foliage version: MC1.12-2.2.0

The area where the portal is rendered does not cull adjacent faces that are occluded whilst the portal view is rendered. This causes issues with mod's such as Better Foliage, as seen below, where it draws additional quads for the un-culled face.

Screenshot of BetterFoliage conflict

@Johni0702
Copy link
Owner

This is a bit tricky because you actually want to see the grass when looking from the other side (below in overworld or above in nether) but I guess no floating grass in portals is better than too much floating grass in portals.

For future reference: this is the check portal blocks currently fail.

@Johni0702 Johni0702 added the compatibility Third-party mod compatibility issues label Jun 1, 2019
@Johni0702
Copy link
Owner

Actually, this is more troublesome to resolve than I though it would be and will probably also require changes on BetterFoliage's part. At the very least octarine-noise/BetterFoliage#173 should be fixed, which, depending on how it's implemented, might even be enough, so I'm closing this issue in favor of that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Third-party mod compatibility issues
Projects
None yet
Development

No branches or pull requests

2 participants