Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Far away chunks don't have an animation #7

Closed
CalXee opened this issue Mar 10, 2021 · 2 comments
Closed

Far away chunks don't have an animation #7

CalXee opened this issue Mar 10, 2021 · 2 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@CalXee
Copy link

CalXee commented Mar 10, 2021

Chunks loading in far away appears like vanilla without the animation.

Minecraft.1.16.5.-.Singleplayer.2021-03-10.14-54-49.mp4
@Johni0702
Copy link
Owner

Quick explanation of how the mod works:

The way Fade In Chunks does its fading is to not actually change the chunks' opacity (cause that's complicated with caves and transparent blocks and such) but to instead interpolate each pixel between its normal color and the background color (I believe that's how bedrock does it as well).
The easy way to do this is to assume that background color is the same thing as fog color, which is true in most cases. and in those were it isn't, vanilla already has what I would consider a graphics bug in that you can clearly make out the edge of foggy mountains when really the point of the fog was to fade them into the background. so, if one were to fix this via a mod, having it as its own dedicated mod would be valuable and it would also fix the fade in effect, meaning just assuming background color = fog color isn't too bad of an assumption.

So they do have an animation but it's fading from foggy to foggy. This is just an unfortunate shortcoming of how the whole thing is implemented.
Fixing this would effectively yield aforementioned fog-fix mod and that is something I'd like to do eventually but as explained it'll be its own mod, so I'm closing this issue as "working as intended" (or "vanilla bug" if you will).

@Johni0702 Johni0702 added bug Something isn't working wontfix This will not be worked on labels Mar 11, 2021
@CalXee
Copy link
Author

CalXee commented Mar 11, 2021

Coolio, thanks for the explanation! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants