Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden format-string usage #145

Closed
johnkerl opened this issue Jun 23, 2017 · 2 comments
Closed

Harden format-string usage #145

johnkerl opened this issue Jun 23, 2017 · 2 comments
Labels
go-port Things which will be addressed in the Go port AKA Miller 6

Comments

@johnkerl
Copy link
Owner

With regard to #143: fmtnum lets people use arbitrary format strings which may be nonsensical for the thing being sprintfed. We should check the ending of the format string (s, d, u, x, lld, llu, llx,f, g, lf, lg, etc.) against the runtime type.
@johnkerl johnkerl mentioned this issue Jun 23, 2017
Closed
@johnkerl
Copy link
Owner Author

This will be addressed in the Go port (#372) -- namely, format strings will be parsed and pre-processed rather than passed directly to the underlying printf. That will include type-checking/type-casting at the callsite.

@johnkerl johnkerl added go-port Things which will be addressed in the Go port AKA Miller 6 on deck labels Nov 15, 2020
@johnkerl
Copy link
Owner Author

johnkerl commented Nov 1, 2021

#717

@johnkerl johnkerl closed this as completed Nov 1, 2021
@johnkerl johnkerl removed the on deck label Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
go-port Things which will be addressed in the Go port AKA Miller 6
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johnkerl