Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miller versus mlr - naming issues #360

Closed
rubyFeedback opened this issue Aug 22, 2020 · 3 comments
Closed

miller versus mlr - naming issues #360

rubyFeedback opened this issue Aug 22, 2020 · 3 comments

Comments

@rubyFeedback
Copy link

Hey John,

Sorry for being nitpicky here.

I recently discovered miller so I proceeded to download it.

We can see lots of options:

https://github.com/johnkerl/miller/releases/download/v5.9.0/miller-5.9.0-1.src.rpm

Also:

https://github.com/johnkerl/miller/releases/download/v5.9.0/mlr-5.9.0.tar.gz

This was where I got confused ... "mlr" ... isn't the name miller?

We also have this tarball:

https://github.com/johnkerl/miller/archive/v5.9.0.tar.gz

which extracts to ...

miller-5.9.0

I would suggest something like:

https://github.com/johnkerl/miller/releases/download/v5.9.0/miller-5.9.0.tar.gz

Or so that also expands to "miller-5.9.0". This would be the simplest IMO.

The "mlr" tarballs are a bit confusing. Perhaps you have totally valid reasons for
using it, but to me, as a first-time visitor, it is a bit confusing. (To clarify why I
even mention this; I actually collect source archives on my own via self-written
ruby scripts, and then use that to compile e. g. a linux system. The code in
miller works fine; for me it would be preferrable if the naming scheme in use
would be simpler and more "streamlined" - but of course I also don't know other
reasons, which may explain the naming scheme in use, so please excuse
that too. Do feel free to close this issue at any moment in time - it is so miniscule
that I don't even know whether it should be raised at all or not.

@johnkerl
Copy link
Owner

Thanks @rubyFeedback !! You are TOTALLY right and if I had it to do all over again I would not have named the tool twice. :(

The docs say "miller" but the command-line tool is mlr. And as you point out some of the tar-file names have mlr but really should have mlr in their names.

I think if I changed all the miller to mlr (or vice versa) things would break in various distros ...

One thing I think I might be able to do without breaking anything is putting 'miller' in the name

https://github.com/johnkerl/miller/releases/download/v5.10.0/mlr-5.10.0.tar.gz

although some of the distros' auto-update scripts might be triggering on the current spelling. Regardless that should be something I can flush out with the various distro-package maintainers ...

@skitt
Copy link
Contributor

skitt commented Sep 3, 2020

The Debian package looks for tags under https://github.com/johnkerl/miller/tags and extracts the version without caring about the prefix. I can’t remember off-hand what the Fedora version check does...

@johnkerl
Copy link
Owner

@rubyFeedback for 5.10.3, and for 6.0.0 (coming soon!) and beyond the naming convention is miller-i.j.k.tar.gz. (See also https://github.com/johnkerl/miller/blob/main/create-release-tarball)

Thank you!! :)

@johnkerl johnkerl removed the active label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants