No Activity leaking #19
Conversation
Organize build scripts a bit centralizing some shared project properties Only apply maven_push if nexusUsername is defined
Auto release it onDestroy for ICS+, older versions must call cancelAll(Activity) or cancelAll() at earliest convenience Use one MsgManager per Activity This way Activity A won't have to wait for AppMsgs belonging to Activity B to be removed in order to show A's AppMsgs
|
Hello, Thanks for this implementation of croutons, it feels cleaner than the other one around, I found this issue in the demo app when you press several buttons then rotate your device and press a bunch more the rotate again, then press a bunch more those will get delayed until other leaked Activities finish "showing" them D: |
|
@johnkil Do you mind taking a look at this? I have a bunch of cool stuff ready to merge based on this one, at glance:
|
|
@eveliotc Thanks for contributing. It's a very nasty bug. Your contribution is very useful! |
|
Wow, sticky messages and custom animations look very impressive! Great work @eveliotc! I will wait for your pull-request ))) |
|
@johnkil Err it seems you closed it instead of merge it 😱 |
|
Sorry, it's my fault 😁 |
|
Cool, I'm gonna send over the others so you can take a look and merge them 👍 |
|
deal 👌 |
Currently Activities are being leaked for as long they are kept in the queue, this PR aims to fix this issues by:
onDestroyfor ICS+, older versions must callcancelAll(Activity)(preferred) orcancelAll()at earliest convenience.MsgManagerperActivity, this wayActivityA won't have to wait forAppMsgs belonging toActivityB to be removed in order to show A'sAppMsgs