Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add music indicator to YouTube videos? Maybe color? #179

Closed
johnmaguire opened this issue Jan 5, 2021 · 7 comments
Closed

Add music indicator to YouTube videos? Maybe color? #179

johnmaguire opened this issue Jan 5, 2021 · 7 comments

Comments

@johnmaguire
Copy link
Owner

I have to guess, given YT Music, and the fact that YouTube has categories, we can determine whether the video is actually a song. If it is, maybe we could use the headphone emoji, or a music (♫ / ♪) symbol to show it as such in the channel?

@rijandev
Copy link

rijandev commented Mar 8, 2021

John I’d like to contribute to this project. I am new to Open source contribute. How do you suggest I go about adding the music signs?

@johnmaguire
Copy link
Owner Author

johnmaguire commented Mar 8, 2021

Hi @rijandev -

The first step would be checking the Youtube Data API to find a way to detect if the video belongs to a music category.

The next step would be to check for this data in the plugin itself (probably in _get_video_info), and add some sort of symbol in the event that you detect that category (in _parse_item): https://github.com/JohnMaguire/Cardinal/blob/master/plugins/youtube/plugin.py

Finally, test the functionality manually by connecting the bot to an IRC network and trying .yt <some song name> as well as pasting a URL to a music video, and verifying that it correctly adds the music symbols. You shouldn't need to request an API key, as a Youtube API key is included in this repository (since Youtube doesn't rate limit or anything.)

@aaitbr
Copy link

aaitbr commented Mar 31, 2021

Hey @johnmaguire
I'm new to the world of contribution. Can i start by working on this one ? if it's not done yet !

@johnmaguire
Copy link
Owner Author

@aaitbr Please go ahead! This API might provide a list of categories, which we can check to see if there's any way to find music-related ones: https://developers.google.com/youtube/v3/docs/videoCategories/list

@aaitbr
Copy link

aaitbr commented Mar 31, 2021

@johnmaguire Thank u ! i'll see that
& I'll let you know if anything is unclear ! if you don't mind

@MelstromH
Copy link

Hi, is this issue still open? It seems that several other people have made attempts.

@johnmaguire
Copy link
Owner Author

Thanks, you're correct, this issue was resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants