Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace setup function with entrypoint #186

Closed
johnmaguire opened this issue Feb 6, 2021 · 0 comments
Closed

Replace setup function with entrypoint #186

johnmaguire opened this issue Feb 6, 2021 · 0 comments
Labels
good first issue internals

Comments

@johnmaguire
Copy link
Owner

johnmaguire commented Feb 6, 2021 •
edited
Loading

Currently, plugins are required to instantiate like this:

def setup(cardinal, config):
    return MyPlugin(cardinal, config)

Instead, we could simply do this:

entrypoint = MyPlugin

The order of cardinal and config also should not matter - and it should be possible to request config without requesting cardinal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue internals
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johnmaguire