Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HH] is illegal, but this softerware does't throw any exception. #12

Closed
goldwind-ting opened this issue Oct 30, 2021 · 3 comments
Closed

Comments

@goldwind-ting
Copy link

    @Test
    public void two_adjacent_h() throws IOException {
        Graph g = Parser.strict("[HH]");
    }

The test runs successfully, but [HH] is illegal!

@johnmay
Copy link
Owner

johnmay commented Oct 30, 2021

Illegal according to who?

@goldwind-ting
Copy link
Author

goldwind-ting commented Oct 31, 2021

Illegal according to who?

A post referred in the repo. See OpenSMILES.

@johnmay
Copy link
Owner

johnmay commented Oct 31, 2021

I helped write the OpenSMILES spec and it’s more important for writing than reading. Beam accepts [HH] as input but will not emit it as output. Think about it like this, if no toolkit can read them how can you fix them.

@johnmay johnmay closed this as completed Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants