Using matching implementation in jgrapht

[jkinable]

Hi John,
I'm one of the developers/maintainers of the open source graph library JGrapht . I'm currently revising some of the matching algorithms in our library. While doing so I came across your matching implementation for maximum cardinality matchings (beam/core/src/main/java/uk/ac/ebi/beam/MaximumMatching.java). It seems that this implementation is faster than the implementation we currently have in our library. Therefore, with your permission, I would like to include your version in the library. Obviously, you'll remain the author of the code, and you'll be mentioned on our 'Contributors' page. No additional effort from your side is required.

I made some modifications to your matching code to make it compatible with jgrapht:
Proposed matching implementation in jgrapht
(This is not the final version; I'll have to do some additional testing, streamlining and cleanup )

Thanks!

[johnmay]

Sure no problem but append yourself as an author and to copyright (or whatever JGraphT's policy is there) as you did the adaption. Maybe change the wording on the class javadoc slightly to indicate lineage, something like:

/** 
 * This implementation was ported from Beam SMILES 
 * toolkit (<a href="https://github.com/johnmay/beam">beam</a>) which was adapted 
 * from D Eppstein's python code 
 * (<a href="http://www.ics.uci.edu/~eppstein/PADS/CardinalityMatching.py">src</a>)providing 
 * efficient tree traversal and handling of blossoms.
 * ...
 *
 */

Thanks for reaching out.