Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade node-notifier or make it a peer dependency #52

Closed
hisuwh opened this issue Jan 13, 2022 · 2 comments · Fixed by #53
Closed

Upgrade node-notifier or make it a peer dependency #52

hisuwh opened this issue Jan 13, 2022 · 2 comments · Fixed by #53

Comments

@hisuwh
Copy link
Contributor

hisuwh commented Jan 13, 2022

Expected Behaviour

node-notifier needs to be updated to 8.0.1 or later to address: GHSA-5fw9-fq32-wv5p
Or it could probably be made a peer dependency.

Actual Behaviour

Depends on version less than 8.0.1

Steps to Reproduce the Problem

run npm audit in package dependent on fork-ts-checker-notifier-webpack-plugin
@johnnyreilly
Copy link
Owner

If you'd like to submit a PR I'll take a look

@hisuwh hisuwh mentioned this issue Jan 14, 2022
Merged
@hisuwh
Copy link
Contributor Author

hisuwh commented Jan 14, 2022

@johnnyreilly done.

@hisuwh hisuwh mentioned this issue Jan 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix all npm audit issues
2 participants
@johnnyreilly @hisuwh