Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass instructions missing in README #84

Closed
0x-r4bbit opened this issue Oct 6, 2014 · 8 comments
Closed

Sass instructions missing in README #84

0x-r4bbit opened this issue Oct 6, 2014 · 8 comments

Comments

@0x-r4bbit
Copy link

Hi there!

I just wanted to dry-run your pixyll theme and cloned the repo etc. Unfortunately, it doesn't work out of the box, if one doesn't run a sass compiler to get a proper pixyll.css file.

Would you mind updating the readme accordingly? Otherwise it could be very annoying for other users.

Also, running trying to compile css/pixyll.scss doesn't work due to error:

Syntax error: Invalid CSS after "-": expected number or function, was "--"
        on line 1 of css/pixyll.scss
  Use --trace for backtrace.
@johno
Copy link
Owner

johno commented Oct 6, 2014

Hey @PascalPrecht , sorry you're running into trouble with this.

Firstly, Jekyll should be running the Sass compilation automatically. You're encountering a Sass compilation error because Jekyll requires front matter on .sass, .scss, and .coffee files. As a result of the front matter, the pixyll.scss file isn't actually a valid Sass file (unfortunate, I know).

How are you running the project? When you run $ jekyll serve or $ jekyll build the Sass will be compiled and placed in _site/css/pixyll.css. If you run the server with the $ jekyll serve command the built website should be served up at localhost:4000.

Also, I'm happy to add anything to the documentation to make it easier for getting people up and running quickly. So, once we figure out what this issue is I'll include any relevant info to the README. Thanks!

@0x-r4bbit
Copy link
Author

Hey @johnotander thanks for answering so quickly.

I simply run jekyll serve --watch and it doesn't compile sass files automatically. And it's just that. The serving works.

Jekyll version is 1.4.2

@anandrajaram
Copy link

@PascalPrecht : I had the same issue and it went away once I updated to the latest jekyll version

% jekyll -version
jekyll 2.4.0

@0x-r4bbit
Copy link
Author

@anandrajaram interesting! Will update now and let you guys know if it helped.

@0x-r4bbit
Copy link
Author

Aaaaand it worked! Thank you! Maybe updating the docs accordingly would be great! Closing this one.

@johno
Copy link
Owner

johno commented Oct 6, 2014

I will update the docs to note the required version. Thanks @PascalPrecht and @anandrajaram !

@anandrajaram
Copy link

Native Sass Support was introduced 2.0+ http://jekyllrb.com/news/2014/05/06/jekyll-turns-2-0-0/

@johno
Copy link
Owner

johno commented Oct 6, 2014

Thanks @anandrajaram, I'm adding that link to the README right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants