Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launching extension clears all color settings #258

Closed
Nibblesh opened this issue Aug 16, 2019 · 1 comment

Comments

@Nibblesh
Copy link

@Nibblesh Nibblesh commented Aug 16, 2019

Versions (please complete the following information):

VS Code Version: 1.37.0
Commit: 036a6b1d3ac84e5ca96a17a44e63a87971f8fcc8
Date: 2019-08-08T01:24:14.598Z
Electron: 4.2.7
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Linux x64 5.0.0-23-generic
Peacock Version 3.1.0

Describe the bug
A clear and concise description of what the bug is.
Extension clears settings.json workbench.colorCustomizations on launch

To Reproduce
Steps to reproduce the behavior:

Launch VS Code.
project relative .vscode/settings.json is altered by extension

Expected behavior
Extension shouldn't remove the color customisations.

Screenshots

Peek 2019-08-16 11-00

@johnpapa

This comment has been minimized.

Copy link
Owner

@johnpapa johnpapa commented Aug 19, 2019

There was a breaking change in 3.0 where Peacock now relies on a setting for peacock.color. If this is missing, it tries to determine what it is. If it fails to do so, Peacock will remove the colors. This change was necessary - and I try to make the migration work. But it seems to only work if you go from 2.5+ to 3.0+. if you had < 2.5, it cannot figure out the migration. https://papapeacockstorage.z13.web.core.windows.net/changelog/#_3-0-0

You can get it back by setting the color through any of the menu options, such as "enter a color"

I will update the docs and changelog to explain this better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.